Pull request review

Pull Request Review

A Pull Request (PR) is the act of requesting to pull / merge code from one Git branch into another. They are called Pull Requests in GitHub and Merge Requests in Gitlab. They are exactly the same thing, and will have one or the other name in a company depending on the code organisation platform used.

Reviewing pull requests

Always be polite and friendly

A pull request is a place for friendly collaboration. It is not a battleground. Always be nice and friendly to each other.

Misunderstandings can very easily happen

Remember, it is very easy for misunderstandings to happen over a text-based medium. Something you write in a slightly annoyed tone might be read as a fiery insult by the receiver. Just dont do it.

Jokes are okay, but should be used with caution.

Solving disagreements

Strong disagreements happen. It is best to solve these face-to-face, else over a video call, or lastly via synchronous chat.

Pull requests are not the place to have an argument.

Come to the best agreement you can. Then respectfully describe the different viewpoints and what the outcome of the discussion was. If you cannot come to an agreement, escalate to the lead.

Never be sarcastic or ironic. It is rude and almost guaranteed to be misunderstood.